src/ai-providers/google-vertex-anthropic.js (1)

8-11: Remove unused import resolveEnvVariable.

The resolveEnvVariable function is imported but never used in this file. Environment variable resolution is handled by ai-services-unified.js before calling the provider.

♻️ Proposed fix

 import { createVertexAnthropic } from '@ai-sdk/google-vertex/anthropic';
-import { resolveEnvVariable } from '../../scripts/modules/utils.js';
 import { log } from '../../scripts/modules/utils.js';
 import { BaseAIProvider } from './base-provider.js';

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/ai-providers/google-vertex-anthropic.js` around lines 8 - 11, The import
resolveEnvVariable from '../../scripts/modules/utils.js' is unused in this
module; remove that named import so only used symbols (log) are imported,
leaving the other imports (createVertexAnthropic from
'@ai-sdk/google-vertex/anthropic' and BaseAIProvider) untouched; ensure there
are no remaining references to resolveEnvVariable in the file (e.g., in any
functions or class methods) before committing.

src/ai-providers/google-vertex-anthropic.js (2)

13-59: Add direct unit coverage for this adapter.

The only test change in this PR is in the model-selection path, so createVertexAnthropic construction and error handling here are still untested. A small provider-level test would catch regressions in auth and fetch wiring quickly.

Based on learnings: Create unit tests in tests/unit/ai-providers/<provider-name>.test.js that mock the provider's AI SDK module and test each exported function for correct client instantiation, parameter passing, result handling, and error handling.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/ai-providers/google-vertex-anthropic.js` around lines 13 - 59, Add direct
unit tests for the VertexAnthropicProvider to cover client construction and
error handling: write tests under
tests/unit/ai-providers/google-vertex-anthropic.test.js that mock the
createVertexAnthropic export and assert that VertexAnthropicProvider.getClient
passes the correct params (projectId, location, apiKey or credentials mapped to
googleAuthOptions, optional baseURL, and fetch from createProxyFetch) and
returns the mocked client; also include a test where the mocked
createVertexAnthropic throws and verify getClient triggers handleError (spy or
stub on VertexAnthropicProvider.handleError) to exercise the catch path. Use the
unique symbols VertexAnthropicProvider, getClient, createVertexAnthropic,
createProxyFetch, and handleError to locate targets in the code.

---

33-45: Normalize credentials type for safety in both Vertex providers.

isValidCredential() accepts string | object, but getClient() spreads credentials without type checking. While ai-services-unified.js currently normalizes string paths to objects before calling the provider, this defensive gap could cause issues if code evolves. Add type normalization in both google-vertex.js and google-vertex-anthropic.js to ensure consistency between validation and usage.

Suggested normalization

const normalizedCredentials =
  typeof credentials === 'string'
    ? { keyFilename: credentials }
    : credentials;

Apply this before line 139 in google-vertex.js and before line 39 in google-vertex-anthropic.js, then use normalizedCredentials for spreading and fallback assignment.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/ai-providers/google-vertex-anthropic.js` around lines 33 - 45, Normalize
the credentials value before spreading in the provider client setup: in
google-vertex-anthropic.js (and likewise in google-vertex.js) create a
normalizedCredentials variable that converts a string credentials to {
keyFilename: credentials } and leaves objects untouched, then use
normalizedCredentials everywhere you currently spread or assign credentials
(e.g., where authOptions.googleAuthOptions and any getClient() calls use
credentials) so isValidCredential()’s accepted types match actual usage and
avoid runtime type errors.

tests/unit/ai-services-unified.test.js (1)

234-240: Couple the VertexAnthropicProvider mock contract to VertexAIProvider behavior.

Because production VertexAnthropicProvider inherits from VertexAIProvider, duplicating API-key methods inline here can drift from base-provider behavior and hide provider-resolution regressions in unified service tests.

Refactor suggestion

+const createMockVertexProvider = () => ({
+	generateText: jest.fn(),
+	streamText: jest.fn(),
+	generateObject: jest.fn(),
+	getRequiredApiKeyName: jest.fn(() => null),
+	isRequiredApiKey: jest.fn(() => false)
+});
+
+const mockVertexAIProvider = createMockVertexProvider();
+const mockVertexAnthropicProvider = createMockVertexProvider();

 ...
-	VertexAIProvider: jest.fn(() => ({
-		generateText: jest.fn(),
-		streamText: jest.fn(),
-		generateObject: jest.fn(),
-		getRequiredApiKeyName: jest.fn(() => null),
-		isRequiredApiKey: jest.fn(() => false)
-	})),
+	VertexAIProvider: jest.fn(() => mockVertexAIProvider),
 	VertexAnthropicProvider: jest.fn(() => ({
-		generateText: jest.fn(),
-		streamText: jest.fn(),
-		generateObject: jest.fn(),
-		getRequiredApiKeyName: jest.fn(() => null),
-		isRequiredApiKey: jest.fn(() => false)
-	})),
+	VertexAnthropicProvider: jest.fn(() => mockVertexAnthropicProvider),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/unit/ai-services-unified.test.js` around lines 234 - 240, The
VertexAnthropicProvider test mock duplicates API-key methods and should delegate
those to the VertexAIProvider behavior instead of hardcoding them; update the
VertexAnthropicProvider jest.fn mock to reuse or extend the VertexAIProvider
mock/implementation for getRequiredApiKeyName and isRequiredApiKey (e.g., obtain
the VertexAIProvider mock instance or prototype and call/assign its
getRequiredApiKeyName and isRequiredApiKey into the VertexAnthropicProvider
mock) so the unified tests track base-provider behavior and avoid drift.